chore: Use cargo-hack --no-private option instread of --ignore-private #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tottoto
force-pushed
the
use-cargo-hack-no-private-option
branch
from
738271d to
5d081a3
Compare
tottoto
force-pushed
the
use-cargo-hack-no-private-option
branch
from
5d081a3 to
2291caa
Compare
tottoto
force-pushed
the
use-cargo-hack-no-private-option
branch
from
2291caa to
66b8901
Compare
tottoto
force-pushed
the
use-cargo-hack-no-private-option
branch
from
66b8901 to
770be29
Compare
LucioFranco
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improves ci by using
cargo-hack's new feature.Solution
Uses
cargo-hack's more powerful--no-privateoption (doc) to avoid checking local crates, which is introduced recently.