refactor(server): Use SWOOLE_BASE
#119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leocavalcante
added
the
enhancement
GitHub Codespaces
huangdijia
approved these changes
Mar 26, 2024
|
I think it might be better to let the user choose when creating the project |
|
When creating a project, users may not understand the difference between the two modes. |
|
From a developer experience perspective, would be nice to start with defaults that adheres to most common use cases, them let people choose when they are in edge cases. Less options for the user (in our case, the developers using Hyperf) is better. |
limingxinleo
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
SWOOLE_BASEas the default server mode right from the template.It is Swoole's default since 5.0 and has been receiving a lot of enhances, especially related to memory,
https://github.com/swoole/swoole-src/releases?q=base&expanded=true