Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to Sphinx for rendering #42

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Transition to Sphinx for rendering #42

wants to merge 5 commits into from

Conversation

thefinn93
Copy link
Contributor

Don't merge this yet, I just want a unified discussion thread. I added the stuff to do Sphinx rendering, and setup a demo at docs2.meshwith.me and h.docs2.meshwith.me. Lemme know what you think. I assume we'll want to theme it eventually, but at this point I suspect there's a lot of stuff that doesn't render properly that i'd like to track down.

@kpcyrd
Copy link
Member

kpcyrd commented Feb 14, 2016

Looks nice and I like the default theme! It looks like all links are currently broken, we'd need to switch those from .html to .md, which would break links in github.

@Kubuxu
Copy link
Contributor

Kubuxu commented Feb 14, 2016

IIRC @thefinn93 was saying something about just doing nginx rewriting. It might not be him but either way it would be good solution.

@thefinn93
Copy link
Contributor Author

  1. Sphinx is supposed to convert the links. I don't know why it isn't. That was the main thing i wanted to fix before moving to this
  2. Nginx rewriting is just for serving analytics javascript. If they're coming from hype, they get the hype version of the analytics server, and vice versa.
  3. I think there are better themes out there, but for now the default one is acceptable

Geoffroy Schmitlin and others added 3 commits February 14, 2016 22:15
Added a custom sphinx theme based on default. Added menu to sidebar. …
@benhylau
Copy link
Member

Like these messed up section headers: https://docs2.meshwith.me/config/shorewall-and-vpn-gateway-howto.html

@Trimardio
Copy link

Trimardio commented Jul 21, 2016

Like these messed up section headers: https://docs2.meshwith.me/config/shorewall-and-vpn-gateway-howto.html

This particular file isn't valid as .md because there is a lack of spaces between "#" and the words. Well actually github and browser apparently support this very well but sphinx doesn't by default, and I don't really see a way to change it, because that would involve changing the text of the files before sphinx process it and I have still have no idea how to do that.

Most of the change I was able to do where after the process by sphinx.

Should we simply fix the files that forgot the spaces between "#" and the title?

@ansuz
Copy link
Member

ansuz commented Oct 16, 2016

Yes, we should fix the files. Most Markdown processors require them.

@Trimardio
Copy link

So I made some modifications. I'm not really satisfied with the result, but I'm not too sure what to change, so feedback is very welcome!

http://ns346455.ip-91-121-136.eu/hyperboria-docs/_build/html/

Modifications:
-capacity to switch between pages
-highlight of current page in the menu
-added "todo" pages
-menu is separated between current page chapter on top and all pages in the website (that's the weirdest thing I introduced in here, does anyone have an idea to avoid this from a design point of view?)

Also I know Danielo was working on some new design ideas he had and it looked very promising, does anyone know if he is still around?

@ansuz
Copy link
Member

ansuz commented Oct 31, 2016

Looks pretty good. Thanks.

I'll review more thoroughly in a few days and see about pulling things in.

@jonathancross
Copy link

Is this still being worked on?

@ansuz
Copy link
Member

ansuz commented Mar 23, 2019

not by me

@Trimardio
Copy link

Not currently but I have some spare time coming soon, so if you have any suggestion I'm all ears

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants