Create systemd socket activation. #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
force-pushed
the
hype/socket-activ
branch
2 times, most recently
from
3f12e84
to
a31f27b
Compare
|
using |
| @@ -0,0 +1,4 @@ | |||
| #!/usr/bin/env sh | |||
| PIPE_NAME="client-core-$(tr -cd 'a-f0-9' < /dev/urandom | head -c 8)" | |||
There was a problem hiding this comment.
Wonder if it'd be nicer to use openssl rand -hex 8 instead of shelling out to two utils?
There was a problem hiding this comment.
both those utils are available in basic installation.
Either way I will be swapping this script with a C program.
There was a problem hiding this comment.
If it's part of the systemd stuff, it should be in contrib/systemd/
There was a problem hiding this comment.
It's to support inetd-style socket activation, so not systemd-specific.
Kubuxu
force-pushed
the
hype/socket-activ
branch
from
a31f27b
to
e1d772c
Compare
In future the socket activation IMHO should be standard way of starting cjdns. Thanks to that configurators don't have to know anything about cjdroute placement to start cjdns.
This solves netcat incompatiblity issues.
Kubuxu
force-pushed
the
hype/socket-activ
branch
from
e1d772c
to
24cdea6
Compare
|
The trap was reworked to be C program. I'd need some external configuration to test it (or I might have to start writing my own). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In future the socket activation IMHO should be standard way of starting
cjdns. Thanks to that configurators don't have to know anything about
cjdroute placement to start cjdns and it makes starting it much much easier,
I would like to hear your input about socket activation in general.
In this scheme configurator would connect
/run/cjdns/cjdns.socketUNIX socket which causes new instance of cjdns to start. It then has to send initial configuration (admin info and private key) and switch to admin port.This is experimental and needs yet to be tested. (possibly by allowing current configurator to be stand-alone).
Implementation for
initdsystems is possible (inetd).