forked from cjdelisle/cjdns
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic peers #124
Open
cyisfor
wants to merge
13
commits into
hyperboria:master
Choose a base branch
from
cyisfor:dynamic-peers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dynamic peers #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What the heck were they even doing with oargList...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I basically wanted to rewrite dynamicEndpoints.py using tools/* instead, since those are maintained.
But since logging is borked, and probably not intended to be used as an event signaling interface, I ended up using a polling algorithm instead, which should actually be easier, since it doesn't require the node to log anything, or remember subscriptions.
Just tested it, and got my netbook to connect to my home server. Still can't loop out of the LAN and back into it by trying to connect with my external IP, but that's b/c my ISP's router sucks, nothing about cjdns.
Also check out promise.js. It's like the regular nodejs promise, except that I'm not lying when I say mine is "bare bones".