Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wheel Zoom plugin #1313

Merged
merged 33 commits into from
Sep 26, 2023
Merged
Show file tree
Hide file tree
Changes from 32 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
be3e228
wip
VillageR88 Sep 25, 2023
d9cb8e2
wip
VillageR88 Sep 25, 2023
8e2bfdc
wip
VillageR88 Sep 25, 2023
6ce511f
wip
VillageR88 Sep 25, 2023
29a4305
wip
VillageR88 Sep 25, 2023
431f6d0
wip
VillageR88 Sep 25, 2023
012d362
Merge branch 'master' of https://github.com/VillageR88/hypertuner-cloud
VillageR88 Sep 25, 2023
ee166f4
wip
VillageR88 Sep 25, 2023
389174f
Merge branch 'master' of https://github.com/VillageR88/hypertuner-cloud
VillageR88 Sep 25, 2023
1ff4325
wip
VillageR88 Sep 25, 2023
6a69ddf
Merge branch 'master' of https://github.com/VillageR88/hypertuner-cloud
VillageR88 Sep 25, 2023
0a09873
wip
VillageR88 Sep 25, 2023
0cbd8a8
Merge branch 'master' of https://github.com/VillageR88/hypertuner-cloud
VillageR88 Sep 25, 2023
0348166
wip
VillageR88 Sep 25, 2023
674eb3e
Merge branch 'master' of https://github.com/VillageR88/hypertuner-cloud
VillageR88 Sep 25, 2023
ba7d9aa
wip
VillageR88 Sep 25, 2023
d5ae164
Revert "wip"
VillageR88 Sep 25, 2023
ffa6130
wip
VillageR88 Sep 25, 2023
5ee4200
Merge branch 'master' of https://github.com/VillageR88/hypertuner-cloud
VillageR88 Sep 25, 2023
4e23bb0
wip
VillageR88 Sep 25, 2023
e082133
Merge branch 'master' of https://github.com/VillageR88/hypertuner-cloud
VillageR88 Sep 25, 2023
3c86fea
wip
VillageR88 Sep 25, 2023
af97033
Merge branch 'master' of https://github.com/VillageR88/hypertuner-cloud
VillageR88 Sep 25, 2023
776c1ef
wip
VillageR88 Sep 25, 2023
4596843
commit
VillageR88 Sep 25, 2023
8a1d517
Merge branch 'master' of https://github.com/VillageR88/hypertuner-cloud
VillageR88 Sep 25, 2023
8cfaf5f
commit
VillageR88 Sep 26, 2023
9e2333f
wip
VillageR88 Sep 26, 2023
1eddeab
commit
VillageR88 Sep 26, 2023
2632049
commit
VillageR88 Sep 26, 2023
fff4f0c
Update tsconfig.json
VillageR88 Sep 26, 2023
7d21fd5
Remove extra new lines
VillageR88 Sep 26, 2023
ff119e4
Add camelCase, remove unnecesary code
VillageR88 Sep 26, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# automatically normalize line endings
* text=auto

# force bash scripts to always use LF line endings
*.sh text eol=lf
3 changes: 2 additions & 1 deletion src/components/Logs/LogCanvas.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import UplotReact from 'uplot-react';
import { Colors } from '../../utils/colors';
import { colorHsl, formatNumberMs } from '../../utils/numbers';
import { isNumber } from '../../utils/tune/expression';
import mouseZoomPlugin from '../../utils/uPlot/mouseZoomPlugin';
import touchZoomPlugin from '../../utils/uPlot/touchZoomPlugin';

export interface SelectedField {
Expand Down Expand Up @@ -144,7 +145,7 @@ const LogCanvas = ({
sync: { key: plotSyncKey },
points: { size: 7 },
},
plugins: [touchZoomPlugin()],
plugins: [touchZoomPlugin(), mouseZoomPlugin()],
},
};
},
Expand Down
3 changes: 2 additions & 1 deletion src/components/TriggerLogs/CompositeCanvas.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import uPlot from 'uplot';
import UplotReact from 'uplot-react';
import { Colors } from '../../utils/colors';
import { CompositeLogEntry } from '../../utils/logs/TriggerLogsParser';
import mouseZoomPlugin from '../../utils/uPlot/mouseZoomPlugin';
import touchZoomPlugin from '../../utils/uPlot/touchZoomPlugin';
import LogsPagination from './LogsPagination';

Expand Down Expand Up @@ -103,7 +104,7 @@ const CompositeCanvas = ({ data, width, height }: Props) => {
drag: { y: false },
points: { size: 7 },
},
plugins: [touchZoomPlugin()],
plugins: [touchZoomPlugin(), mouseZoomPlugin()],
});
}, [data, width, height, indexFrom, indexTo]);

Expand Down
3 changes: 2 additions & 1 deletion src/components/TriggerLogs/ToothCanvas.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import uPlot from 'uplot';
import UplotReact from 'uplot-react';
import { Colors } from '../../utils/colors';
import { EntryType, ToothLogEntry } from '../../utils/logs/TriggerLogsParser';
import mouseZoomPlugin from '../../utils/uPlot/mouseZoomPlugin';
import touchZoomPlugin from '../../utils/uPlot/touchZoomPlugin';
import LogsPagination from './LogsPagination';

Expand Down Expand Up @@ -69,7 +70,7 @@ const ToothCanvas = ({ data, width, height }: Props) => {
drag: { y: false },
points: { size: 7 },
},
plugins: [touchZoomPlugin()],
plugins: [touchZoomPlugin(), mouseZoomPlugin()],
});
}, [data, width, height, indexFrom, indexTo]);

Expand Down
141 changes: 141 additions & 0 deletions src/utils/uPlot/mouseZoomPlugin.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,141 @@
import uPlot from 'uplot';
import { Plugin } from 'uplot';

interface WheelZoomPluginOptions {
factor?: number;
animationDuration?: number;
}

function wheelZoomPlugin(options: WheelZoomPluginOptions = {}): Plugin {
const factor = options.factor || 0.9;

let xMin: number;
let xMax: number;
let yMin: number;
let yMax: number;
let xRange: number;
let yRange: number;
let over = null;
let rect: DOMRect;

function isCtrlPressed(e: MouseEvent): boolean {
return e.ctrlKey || e.metaKey;
}

function clamp(
nRange: number,
nMin: number,
nMax: number,
fRange: number,
fMin: number,
fMax: number,
): [number, number] {
let newNMin = nMin;
let newNMax = nMax;

if (nRange > fRange) {
newNMin = fMin;
newNMax = fMax;
} else if (nMin < fMin) {
newNMin = fMin;
newNMax = fMin + nRange;
} else if (nMax > fMax) {
newNMax = fMax;
newNMin = fMax - nRange;
}

return [newNMin, newNMax];
}

return {
hooks: {
ready(u: uPlot) {
xMin = u.scales.x.min ?? 0;
xMax = u.scales.x.max ?? 0;
yMin = u.scales.y.min ?? 0;
yMax = u.scales.y.max ?? 0;
xRange = xMax - xMin;
yRange = yMax - yMin;
over = u.over;
rect = over.getBoundingClientRect();

over.addEventListener('mousedown', (e: MouseEvent) => {
if (e.button === 1) {
e.preventDefault();

const left0 = e.clientX;
const scXMin0 = u.scales.x.min;
const scXMax0 = u.scales.x.max;
const xUnitsPerPx = u.valToPos(1, 'x') - u.valToPos(0, 'x');

function onmove(e: MouseEvent) {
karniv00l marked this conversation as resolved.
Show resolved Hide resolved
e.preventDefault();

const left1 = e.clientX;
const dx = xUnitsPerPx * (left1 - left0);

u.setScale('x', {
min: (scXMin0 ?? 0) - dx,
max: (scXMax0 ?? 0) - dx,
});
}

document.addEventListener('mousemove', onmove);
karniv00l marked this conversation as resolved.
Show resolved Hide resolved
}
});

over.addEventListener('wheel', (e: WheelEvent) => {
e.preventDefault();

if (!isCtrlPressed(e)) {
return;
}

const cursor = u.cursor;

const { left, top } = cursor;
const leftPct = (left || 0) / rect.width;
const btmPct = 1 - (top || 0) / rect.height;
const xVal = u.posToVal(left || 0, 'x');
const yVal = u.posToVal(top || 0, 'y');
const oxRange = (u.scales.x.max || 0) - (u.scales.x.min || 0);
const oyRange = (u.scales.y.max || 0) - (u.scales.y.min || 0);

const nxRange = e.deltaY < 0 ? oxRange * factor : oxRange / factor;
let nxMin = xVal - leftPct * nxRange;
let nxMax = nxMin + nxRange;
[nxMin, nxMax] = clamp(nxRange, nxMin, nxMax, xRange, xMin, xMax);

const nyRange = e.deltaY < 0 ? oyRange * factor : oyRange / factor;
let nyMin = yVal - btmPct * nyRange;
let nyMax = nyMin + nyRange;
[nyMin, nyMax] = clamp(nyRange, nyMin, nyMax, yRange, yMin, yMax);

u.batch(() => {
u.setScale('x', {
min: nxMin,
max: nxMax,
});

u.setScale('y', {
min: nyMin,
max: nyMax,
});
});
});

document.addEventListener('keydown', (e: KeyboardEvent) => {
if (e.ctrlKey || e.metaKey) {
}
});

document.addEventListener('keyup', (e: KeyboardEvent) => {
if (!e.ctrlKey && !e.metaKey) {
}
});
karniv00l marked this conversation as resolved.
Show resolved Hide resolved
},
},
};
}

export default wheelZoomPlugin;