Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some bugs in the notebook viewer #1084

Merged
merged 2 commits into from
May 1, 2024
Merged

Conversation

andrewheumann
Copy link
Member

@andrewheumann andrewheumann commented Apr 28, 2024

BACKGROUND:

DESCRIPTION:

  • There were a couple minor bugs in the 3d viewer code which resulted in the far plane calculation being wrong, which would cause models not centered on the origin to be clipped / invisible. There were also a couple other little syntax issues.

TESTING:

  • I loaded this model into a notebook and returned it in a cell. (Scratch.dib is a good place to test this out against the local version of extension.dib)
    bad-model.json

image

FUTURE WORK:

  • We should find a way to upgrade the version of threejs in our notebook, so we can support setting DEFAULT_UP to z instead of y, but the recommended CDN approach for three these days requires importMaps, which I couldn't get to work in a notebook context.

This change is Reviewable

@andrewheumann andrewheumann requested a review from wynged April 28, 2024 14:09
Copy link
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@andrewheumann andrewheumann merged commit d246cee into master May 1, 2024
2 checks passed
@andrewheumann andrewheumann deleted the fix-extension-viewer branch May 1, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange behaviour with rendering Model (in dotnet.interactive)
2 participants