Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset space configuration cache when setting catalog path #1080

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

wynged
Copy link
Member

@wynged wynged commented Mar 13, 2024

BACKGROUND:

  • We noticed that when a space type was updated in the content catalog that old values for the instance parameters on ContentElements would persists across multiple executions.

DESCRIPTION:

  • When a catalog path is set we want to be sure that the SpaceConfiguration class will use that new catalog, so we have to clear the catalog that is used for ContentElement retrieval inside SpaceConfiguration

TESTING:

  • I've tested this with the function-SpaceType function and this resolves the stale instance parameter values

FUTURE WORK:

  • Is there any future work needed or anticipated? Does this PR create any obvious technical debt?

REQUIRED:
- [ ] All changes are up to date in CHANGELOG.md.

COMMENTS:

  • Any other notes.

This change is Reviewable

@wynged wynged requested a review from andrewheumann March 13, 2024 14:13
Copy link
Member

@andrewheumann andrewheumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@wynged wynged merged commit 4816fbd into master Mar 13, 2024
2 checks passed
@wynged wynged deleted the reset-space-configuration-cache branch March 13, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants