Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

additional props on contentConfigurations #1072

Merged
merged 4 commits into from
Dec 13, 2023
Merged

additional props on contentConfigurations #1072

merged 4 commits into from
Dec 13, 2023

Conversation

wynged
Copy link
Member

@wynged wynged commented Dec 11, 2023 •
edited by andrewheumann
Loading

BACKGROUND:

  • Add additional properties to ContentConfiguration for future easier compatability.

DESCRIPTION:

  • Add the additional properties dictionary mirroring how we treat elements.

TESTING:

  • Tests still pass, good enough for now.

FUTURE WORK:

  • Is there any future work needed or anticipated? Does this PR create any obvious technical debt?

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

COMMENTS:

  • Any other notes.

This change is Reviewable

@wynged wynged requested a review from andrewheumann December 11, 2023 20:58
andrewheumann
andrewheumann approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@andrewheumann andrewheumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@wynged wynged merged commit 37fe9a6 into master Dec 13, 2023
2 checks passed
@wynged wynged deleted the add-additional-properties branch December 13, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewheumann andrewheumann andrewheumann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wynged @andrewheumann