Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: ToSTEP call added #1059

Conversation

samil-akhmedov
Copy link
Contributor

@samil-akhmedov samil-akhmedov commented Nov 18, 2023

BACKGROUND:

  • Writing model data to the memory stream doesn't work correctly (model.ToIFC) as it lacks the ToSTEP method call.
  • Not leaving the underlying stream open while writing model data to the memory stream prohibits the subsequent calls for that stream.

DESCRIPTION:

  • The ToSTEP method call was added to the ToIFC method.
  • leaveOpen: true parameter was added to the StreamWriter instance inside the ToIFC method.

TESTING:

  • Write any model data into MemoryStream instance.

FUTURE WORK:

  • No further work is required.

This change is Reviewable

@samil-akhmedov samil-akhmedov changed the title ToSTEP call added Bugfix: ToSTEP call added Nov 22, 2023
Copy link
Contributor

@jamesbradleym jamesbradleym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@jamesbradleym jamesbradleym merged commit 2e7592e into hypar-io:master Feb 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants