Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more notebook formatters #1053

Merged
merged 3 commits into from
Nov 9, 2023
Merged

add more notebook formatters #1053

merged 3 commits into from
Nov 9, 2023

Conversation

andrewheumann
Copy link
Member

@andrewheumann andrewheumann commented Nov 6, 2023 •
edited
Loading

BACKGROUND:

  • The AEC Tech Workshop benefitted from having additional formatters to render solids, representations, and transforms directly in notebooks when returned.

DESCRIPTION:

  • Adds formatters
  • Updates scratch.dib to reference extension directly, so it can be useful as a test.

This change is Reviewable

@andrewheumann andrewheumann requested a review from wynged November 6, 2023 13:24
@andrewheumann andrewheumann changed the title add more formatters add more notebook formatters Nov 6, 2023
wynged
wynged approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@andrewheumann andrewheumann merged commit 213f4b7 into master Nov 9, 2023
1 check passed
@andrewheumann andrewheumann deleted the add-more-formatters branch November 9, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wynged wynged wynged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewheumann @wynged