Fix Vector3.DistanceTo(Polygon). Add custom implementations of ToPolyline (issue #495) #1046
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BACKGROUND:
DistanceTo
Polygon and Polyline are not consistent. #945DESCRIPTION:
ToPolyline
function forIndexedPolycurve
,Polyline
andPolygon
.a) In
Polyline
andPolygon
they produce Polyline with the same points as original object instead of dividing by 10 segments.b) In
IndexedPolycurve
lines are always represented by 2 points, curve are interpolated by their corresponding ToPolyline function.IndexedPolycurve
with divisions parameter. End points of curves are added first and then non straight curves are divided uniformly. If number of divisions is less than number of curves - points are uniformly distributed though whole domain, deviating heavily from original shape.TESTING:
REQUIRED:
CHANGELOG.md
.This change is