Updated Intersection method to support multiple representations

[katehryhorenko]

BACKGROUND:

• _bounds and _csg are used by GeometricElement.Intersection method. Both this variables are calculated from SolidOperations. So currently Intersection method ignores RepresentationInstances

DESCRIPTION:
This PR adds:

• CalculateIntersactionPoints and ComputeBounds to the SolidRepresentation. It's a duplicated code from the GeometricElement.
• SolidRepresentations are added to the Bounds calculations and to the Intersections

TESTING:

• I tested it with SVGSection method

FUTURE WORK:

• Add other Representation types to the calculations

REQUIRED:

• All changes are up to date in CHANGELOG.md.

---

This change is 

[andrewheumann]

Looks good! can we add a test or two?

Reviewed 3 of 4 files at r1, all commit messages.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @katehryhorenko)

---

Elements/src/Representations/SolidRepresentation.cs line 150 at r1 (raw file):

        /// <param name="beyondPolygons">The output collection of the polygons beyond the input plane.</param>
        /// <returns>Returns the collection of intersection points.</returns>
        public List<Vector3> CalculateIntersactionPoints(GeometricElement element, Plane plane, out List<Polygon> beyondPolygons)

CalculateIntersactionPoints => CalculateIntersectionPoints :)

---

Elements/src/Representations/SolidRepresentation.cs line 157 at r1 (raw file):

            var csg = SolidOperationUtils.GetFinalCsgFromSolids(SolidOperations, element, true);

            var localCsg = csg.Transform(element.Transform.ToMatrix4x4()); ;

lose extra ; here

[andrewheumann]

And update changelog 😄

Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @katehryhorenko)

[katehryhorenko]

I added two tests :)

Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @andrewheumann)

---

Elements/src/Representations/SolidRepresentation.cs line 150 at r1 (raw file):

Previously, andrewheumann (Andrew Heumann) wrote…

CalculateIntersactionPoints => CalculateIntersectionPoints :)

Done.

---

Elements/src/Representations/SolidRepresentation.cs line 157 at r1 (raw file):

Previously, andrewheumann (Andrew Heumann) wrote…

lose extra ; here

Done.

[andrewheumann]

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @katehryhorenko)

---

Elements/src/GeometricElement.cs line 263 at r2 (raw file):

                foreach (var instance in RepresentationInstances)
                {
                    if (!instance.IsDefault)

can we leave a TODO here about potentially accepting a representation type filter as input?

---

Elements/test/GeometricElementTests.cs line 89 at r2 (raw file):

            var width = 10;
            var height = 10;
            var hhickness = 0.2;

hhickness => thickness

[katehryhorenko]

Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @andrewheumann)

---

Elements/src/GeometricElement.cs line 263 at r2 (raw file):

Previously, andrewheumann (Andrew Heumann) wrote…

can we leave a TODO here about potentially accepting a representation type filter as input?

Done.

---

Elements/test/GeometricElementTests.cs line 89 at r2 (raw file):

Previously, andrewheumann (Andrew Heumann) wrote…

hhickness => thickness

Done.

[andrewheumann]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! 1 of 1 approvals obtained