Skip to content

Commit

Permalink
format comments
Browse files Browse the repository at this point in the history
  • Loading branch information
anthonie-kramer committed Nov 16, 2023
1 parent cef84bb commit a5febf9
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
10 changes: 5 additions & 5 deletions Elements/src/Door.cs
Original file line number Diff line number Diff line change
Expand Up @@ -169,11 +169,11 @@ public override void UpdateRepresentations()
public List<RepresentationInstance> GetInstances(Door door)

Check warning on line 169 in Elements/src/Door.cs

View workflow job for this annotation

GitHub Actions / build-and-test

Missing XML comment for publicly visible type or member 'Door.GetInstances(Door)'
{
var representationInstances = new List<RepresentationInstance>()
{
this.CreateDoorSolidRepresentation(),
this.CreateDoorFrameRepresentation(),
this.CreateDoorCurveRepresentation()
};
{
this.CreateDoorSolidRepresentation(),
this.CreateDoorFrameRepresentation(),
this.CreateDoorCurveRepresentation()
};

return representationInstances;
}
Expand Down
2 changes: 0 additions & 2 deletions Elements/src/StandardWall.cs
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,7 @@ public Opening AddOpening(Polygon perimeter, double x, double y, double depthFro
private Transform GetOpeningTransform(double x, double y)
{
var xAxis = this.CenterLine.Direction();
// Opening transform is still off... `outOfPlane` added because transform is not working correctly
var outOfPlane = xAxis.Cross(Vector3.ZAxis);
// Opening transform is still off?
var openingTransform = new Transform(this.CenterLine.Start + xAxis * x + Vector3.ZAxis * y - outOfPlane, xAxis, xAxis.Cross(Vector3.ZAxis));
return openingTransform;
}
Expand Down
6 changes: 4 additions & 2 deletions Elements/test/DoorTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,17 @@ namespace Elements
public class DoorTest : ModelTest
{
[Fact, Trait("Category", "Examples")]
public void Example()
public void MakeDoorElement()
{
this.Name = "Elements_Door";
this.Name = nameof(MakeDoorElement);

var line = new Line(new Vector3(0, 0, 0), new Vector3(10, 10, 0));
var wall = new StandardWall(line, 0.1, 3.0);
var door = new Door(wall.CenterLine, 0.5, 2.0, 2.0, Door.DOOR_THICKNESS, DoorOpeningSide.LeftHand, DoorOpeningType.SingleSwing);
wall.AddDoorOpening(door);

Assert.Single(wall.Openings);

this.Model.AddElement(wall);
Model.AddElement(door);
}
Expand Down

0 comments on commit a5febf9

Please sign in to comment.