Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support moto 5.0 #76

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Support moto 5.0 #76

merged 1 commit into from
Feb 13, 2024

Conversation

s-t-e-v-e-n-k
Copy link
Contributor

moto 5.0 has been released, and the major change is to pull all of the mocking into one function. Use the new mock_aws function, but continue to support moto 4.2, since it's easy.

  • Added tests for changed code.
  • New or changed APIs are added to our typing examples to ensure our external type hints are sound.
  • Updated documentation for changed code.
    • New functions/classes have to be added to docs/api.md by hand.
    • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
  • Documentation in .md files are written using semantic newlines.
  • Changes (and possible deprecations) are documented in the changelog.

Copy link
Owner

@hynek hynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! This isn't I would be capable or even motivated to figure out on myself. :)

I've added a few simplifications, lmk what you think.

pyproject.toml Outdated Show resolved Hide resolved
tests/test_secrets_awssm.py Outdated Show resolved Hide resolved
moto 5.0 has been released, and the major change is to pull all of the
mocking into one function. Use the new mock_aws function.
@s-t-e-v-e-n-k
Copy link
Contributor Author

@hynek All done, thanks for the review and the suggestions.

Copy link
Owner

@hynek hynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hynek hynek merged commit 5f10e6d into hynek:main Feb 13, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants