Update mint module #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkCherepovskyi
force-pushed
the
feature/distribution
branch
from
041adea to
6172a90
Compare
olegfomenko
reviewed
Jul 9, 2024
types/tokens.go
Outdated
| package types | ||
|
|
||
| const ( | ||
| NativeToken = "aevmos" |
x/accumulator/keeper/keeper.go
Outdated
| GetParams(c sdk.Context) types.Params | ||
| SetParams(c sdk.Context, params types.Params) | ||
| Params(c context.Context, req *types.QueryParamsRequest) (*types.QueryParamsResponse, error) | ||
| DistributeTokens(ctx sdk.Context, fromPool string, isSentToModule bool, amount sdk.Coins, receiverModule string, receiverAddress *sdk.AccAddress) error |
There was a problem hiding this comment.
better define separate functions:
- DistributeToModule
- DistributeToAccount
This will allow to use less arguments and make them clearer to understand
| ) | ||
|
|
||
| if err != nil { | ||
| err = errors.Wrap(err, "sending native coins to address") |
| ) | ||
|
|
||
| if err != nil { | ||
| err = errors.Wrap(err, "sending native coins to module") |
| ) | ||
|
|
||
| if err != nil { | ||
| err = errors.Wrap(err, "sending native coins to module") |
| @@ -0,0 +1,64 @@ | |||
| package main | |||
There was a problem hiding this comment.
do we still need this files?
| @@ -0,0 +1,110 @@ | |||
| package main | |||
There was a problem hiding this comment.
do we still need this files?
There was a problem hiding this comment.
yes, we need this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.