PatternEditor: take note lead-lag into account #2013
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of placing notes at their defined position, both `DrumOatternEditor` and `PianoRollEditor` do now take the lead-lag of each note into account and displace them accordingly. Altering the lead-lag in `NotePropertiesRuler` results in an immediate position update in the editor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of placing notes at their defined position, both
DrumPatternEditorandPianoRollEditordo now take the lead-lag of each note into account and displace them accordingly. Altering the lead-lag inNotePropertiesRulerresults in an immediate position update in the editor.As the lead/lag of a node is an integer between [-1,1] scaling the maximum allowed value of
5ticks we do not run in any trouble, like rescaling lead/lag on different tempo and sample rates, since the editors themselves are tick-based too.Current UI when creating a chord/flam (both as the actual chord and the individual notes dragged into a diagonal to see their lead-lag values):
With this patch it will look like this:
I like it a lot. Previously the amount of lead/lag always felt a little bit esoteric. Now one can really see what is going on.
But the first thing that came to my mind is that it is now able to place on top of each other (three of them in
64resolution). On the other hand, this is not a real issue as it was possible the whole time. It's just the first time you actually see it.Nevertheless, there are a number of UX changes that are required
NotePropertiesRuleras well (the bar will move when dragged up/down?)NotePropertiesRulertoo)2xsymbols to indicate this? Selection will be tricky in such a case. I would suggest rectangles with starting points (Note::__position) to the right of the notes will select the note with the right-most onset first and require another nudge for the note starting left of it and vice versa.But there a couple of other things I need to address first.
@cme what do you think.
Addresses #2010