feat: changing permission verify strategy #1374
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,21 @@ | ||
| import fs from "node:fs"; | ||
| import path from "node:path"; | ||
|
|
||
| import { registerEvent } from "../register-event"; | ||
|
|
||
| const checkFolderWritePermission = async ( | ||
| _event: Electron.IpcMainInvokeEvent, | ||
| testPath: string | ||
| ) => { | ||
| const testFilePath = path.join(testPath, ".hydra-write-test"); | ||
|
There was a problem hiding this comment. style: consider using a more unique filename with timestamp/uuid to avoid potential conflicts |
||
|
|
||
| try { | ||
| fs.writeFileSync(testFilePath, ""); | ||
| fs.rmSync(testFilePath); | ||
|
Comment on lines
+13
to
+14
There was a problem hiding this comment. style: using synchronous fs operations can block the main thread - consider using async writeFile/rm |
||
| return true; | ||
| } catch (err) { | ||
| return false; | ||
| } | ||
|
Comment on lines
+16
to
+18
There was a problem hiding this comment. style: error is silently swallowed - should at least log it for debugging purposes |
||
| }; | ||
|
|
||
| registerEvent("checkFolderWritePermission", checkFolderWritePermission); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: function is marked async but contains no await operations - should either use async fs operations or remove async keyword