-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/accessibility improvements #1121
base: main
Are you sure you want to change the base?
Feature/accessibility improvements #1121
Conversation
@cj-burning could you update the pr after the last update? |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@zamitto any considerations?
Last week I has fixed some conflicts in this PR and some changes were lost because a component had moved to another file. |
this pr adds some accessibility improvements to the application
added aria labels to improve accessibility in the achievement feature
before
2024-10-24.15-41-20.mp4
after
2024-10-24.15-53-57.mp4
removed repetition for screen readers in sidebar
before
2024-10-24.16-24-34.mp4
after
2024-10-24.15-57-27.mp4
added tooltips and screen reader support for the back, search, and clear buttons
before
2024-10-24.16-25-43.mp4
after
2024-10-24.16-04-40.mp4
improved layout keyboard navigation: sidebar can be controlled with arrow keys, and the search bar can be focused with Ctrl + K and blurred with Escape.
after
2024-10-24.16-09-09.mp4
enabled carousel navigation using the Tab key in media previews
before
2024-10-24.16-31-36.mp4
after
2024-10-24.16-16-57.mp4
added aria labels to improve accessibility in the game details sidebar
before
2024-10-24.16-33-14.mp4
after
2024-10-24.16-21-12.mp4