Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ollie(test): fix data race in test #1034

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Nov 11, 2023

Solved issues and/or description of the change

data race in test for ollie driver found by go test -race - fixed by introducing a channel instead of bool variable

this partially fix #1017

Manual test

none

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • New and existing unit tests pass locally with my changes (e.g. by run make test)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

@gen2thomas gen2thomas marked this pull request as ready for review November 11, 2023 18:55
@gen2thomas gen2thomas merged commit 88a0c7a into hybridgroup:dev Nov 11, 2023
2 checks passed
@gen2thomas gen2thomas deleted the fix/ollie branch November 11, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant