Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpio: fix data race in StepperDriver #1029

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Nov 5, 2023

Solved issues and/or description of the change

data race in StepperDriver and EasyDriver found by go test -race - fixed by rework of drivers and its tests

this partially fix #1017

additionally:

  • huge rework (also again for EasyDriver, see pervious commit gpio: fix data race in EasyDriver #1025 ), test improvements and example adjustment
  • add Sleep() function to prevent overheating
  • add signal handler for os interrupts

Manual test

  • OS and Version (Win/Mac/Linux): Linux
  • Adaptor(s) and/or driver(s): raspi with stepper example and L298N based driver

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (e.g. by run make test)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

@gen2thomas gen2thomas force-pushed the fix/gpio_datarace_stepper branch 12 times, most recently from 7188065 to f9ade74 Compare November 9, 2023 19:19
@gen2thomas gen2thomas marked this pull request as ready for review November 9, 2023 19:31
@gen2thomas gen2thomas merged commit a04ce8a into hybridgroup:dev Nov 9, 2023
5 checks passed
@gen2thomas gen2thomas deleted the fix/gpio_datarace_stepper branch November 9, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant