Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpio: fix data race in PIRMotionDriver #1028

Merged
merged 1 commit into from
Nov 1, 2023
Merged

gpio: fix data race in PIRMotionDriver #1028

merged 1 commit into from
Nov 1, 2023

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Nov 1, 2023 •
edited
Loading

Solved issues and/or description of the change

data race in PIRMotionDriver found by go test -race - fixed by rework of driver and its tests

this partially fix #1017

Manual test

none

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (e.g. by run make test)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

@gen2thomas gen2thomas marked this pull request as ready for review November 1, 2023 14:46
@gen2thomas gen2thomas merged commit 9e311b2 into hybridgroup:dev Nov 1, 2023
5 checks passed
@gen2thomas gen2thomas deleted the fix/gpio_datarace_pir branch November 1, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gen2thomas