Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aio: fix data race in AnalogSensorDriver #1024

Merged
merged 1 commit into from
Oct 30, 2023
Merged

aio: fix data race in AnalogSensorDriver #1024

merged 1 commit into from
Oct 30, 2023

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Oct 30, 2023 •
edited
Loading

Solved issues and/or description of the change

data race in aio found by go test -race fixed by introducing a mutex

this partially fix #1017

Manual test

none

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • New and existing unit tests pass locally with my changes (e.g. by run make test)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

@gen2thomas gen2thomas force-pushed the test/fix_datarace branch 2 times, most recently from 737219f to 2096f7f Compare October 30, 2023 18:05
@gen2thomas gen2thomas marked this pull request as ready for review October 30, 2023 18:09
@gen2thomas gen2thomas merged commit 458a1f4 into hybridgroup:dev Oct 30, 2023
5 checks passed
@gen2thomas gen2thomas deleted the test/fix_datarace branch October 30, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gen2thomas