Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(style): switch to gofumpt, activate and fix linter issues #1009

Merged
merged 1 commit into from
Oct 20, 2023
Merged

build(style): switch to gofumpt, activate and fix linter issues #1009

merged 1 commit into from
Oct 20, 2023

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Oct 20, 2023 •
edited
Loading

Solved issues and/or description of the change

run gofumpt, activate linters:

  • gofumpt
  • gofmt
  • gosec
  • goimports
  • unconvert
  • unparam
  • dupword
  • misspell

Manual test

none

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • New and existing unit tests pass locally with my changes (e.g. by run make test)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

@gen2thomas gen2thomas changed the title build(style): switch to gofumpt build(style): switch to gofumpt, activate and fix linter issues Oct 20, 2023
@gen2thomas gen2thomas force-pushed the feature/gofumpt branch 3 times, most recently from 9bbee1f to c9b9301 Compare October 20, 2023 18:15
@gen2thomas gen2thomas marked this pull request as ready for review October 20, 2023 18:18
@gen2thomas gen2thomas merged commit a4a8d10 into hybridgroup:dev Oct 20, 2023
5 checks passed
@gen2thomas gen2thomas deleted the feature/gofumpt branch October 20, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gen2thomas