Skip to content

Commit

Permalink
Update warning about old tool to reference the new tool in the same l…
Browse files Browse the repository at this point in the history
…ine.
  • Loading branch information
hvanbakel committed Sep 17, 2018
1 parent c972c15 commit b04b999
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
3 changes: 1 addition & 2 deletions Project2015To2017.Console/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ private static void ConvertProject(Options options)

ILogger logger = new ConsoleLogger("console", (s, l) => l >= LogLevel.Information, true);

logger.LogWarning("csproj-to-2017 is deprecated and will be removed soon");
logger.LogInformation("Consider migrating to Project2015To2017.Migrate2017.Tool (dotnet migrate-2017)");
logger.LogWarning("csproj-to-2017 is deprecated and will be removed soon. Consider migrating to Project2015To2017.Migrate2017.Tool (dotnet migrate-2017)");

foreach (var file in options.Files)
{
Expand Down
2 changes: 1 addition & 1 deletion Project2015To2017.Console/Project2015To2017.Console.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<RepositoryUrl>https://github.com/hvanbakel/CsprojToVs2017</RepositoryUrl>
<Copyright>Copyright Hans van Bakel</Copyright>
<PackageTags>dotnet csproj conversion vs2015 vs2017</PackageTags>
<Version>3.0.1</Version>
<Version>3.0.2</Version>
<OutputType>Exe</OutputType>
<AssemblyVersion>3.0.0.0</AssemblyVersion>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<RepositoryUrl>https://github.com/hvanbakel/CsprojToVs2017</RepositoryUrl>
<Copyright>Copyright Hans van Bakel</Copyright>
<PackageTags>dotnet csproj fsproj vbproj msbuild conversion vs2015 vs14 vs15 vs2017</PackageTags>
<Version>3.0.1</Version>
<Version>3.0.2</Version>
<OutputType>Exe</OutputType>
<AssemblyVersion>3.0.0.0</AssemblyVersion>
<RestoreAdditionalProjectSources>
Expand Down
2 changes: 1 addition & 1 deletion Project2015To2017/Project2015To2017.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<PackageTags>dotnet csproj conversion vs2015 vs2017</PackageTags>
<Description>Tool for converting a csproj file for VS2015 to VS2017 and beyond.</Description>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<Version>3.0.1</Version>
<Version>3.0.2</Version>
<AssemblyVersion>3.0.0.0</AssemblyVersion>
<LangVersion>7.3</LangVersion>
</PropertyGroup>
Expand Down

3 comments on commit b04b999

@andrew-boyarshin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this commit for? That conflicts with change in my latest PR. No need to revert of course, but seems weird.

@hvanbakel
Copy link
Owner Author

@hvanbakel hvanbakel commented on b04b999 Sep 17, 2018 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-boyarshin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. When I added this warning message I thought there is no point in highlighting too much text as error. But if it causes confusion - sure, why not.

Please sign in to comment.