Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ajphukan upload 1 #55

Merged
merged 13 commits into from
Sep 16, 2016
Merged

Ajphukan upload 1 #55

merged 13 commits into from
Sep 16, 2016

Conversation

ajphukan
Copy link
Contributor

@ajphukan ajphukan commented Sep 15, 2016 •
edited by hustcc
Loading

#19 PR for adding ind_hin (Hindi) in locale folder

@ajphukan
Add files via upload
c314e25 
Hindi translation for locale
@ajphukan
Update locales.js
09462c8 
add ind_hin
@hustcc
Copy link
Owner

hustcc commented Sep 16, 2016 •
edited
Loading

Thank you for your nice work, is ind_hin is the right locale key of Hindi?

The locale key maybe always with the format like [a-z]{2}_[A-Z]{2}.

@ajphukan
Copy link
Contributor Author

I don't know the locale key and it was not in the list too . So , I just made it .. Is there is a limit in the length of local keyword ...

can you suggest the keyword for
country : India
Language : Hindi

There are two more local language in which i like to contribute
country : India
Language : Assamese , Bengali ..

suggest the keyword for these two also please ...

@ajphukan
Copy link
Contributor Author

Are you following these code for starting two letters of keyword

Country code

Sorry for asking so many things ...

@ajphukan
Add files via upload
5957b37 
Locale translation for 
Country: India
Language: Bengali
@ajphukan
Rename ind_hin.js to in_hi.js
2633fd7 
Changing Keyword from ind_hin.js to in_hi.js
@ajphukan
Update locales.js
2688574 
Added in_BG and Changed ind_hin to in_HI
@ajphukan
Rename in_hi.js to in_HI.js
3c6ac0f 
in_hi to in_HI
@hustcc
Copy link
Owner

hustcc commented Sep 16, 2016 •
edited
Loading

Very nice, If you add the locale test cases into tests/locales dir, it will be prefact.

You can write test cases like tests/locales/en.js.

Thank you very much~

@ajphukan
Copy link
Contributor Author

Okk .. @hustcc

@ajphukan
Copy link
Contributor Author

Testing part will take time i will try do it as quickly as possible .

@hustcc hustcc merged commit 2b28e5d into hustcc:master Sep 16, 2016
@ajphukan
Copy link
Contributor Author

Thanks for approving.

@ajphukan ajphukan deleted the ajphukan-upload-1 branch September 19, 2016 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajphukan @hustcc