Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added galician (gl) locale #138

Merged
merged 2 commits into from
Jul 20, 2017
Merged

Added galician (gl) locale #138

merged 2 commits into from
Jul 20, 2017

Conversation

oscarotero
Copy link
Contributor

@oscarotero oscarotero commented Jul 20, 2017

related #19

@hustcc
Copy link
Owner

hustcc commented Jul 20, 2017

Please add testcase, thank you.

You can just see the issue for HOWTO. #19

@oscarotero
Copy link
Contributor Author

Done.
In local, I have a lot of test failures, in all locales. Example:

not ok 1312 should be equal
  ---
    operator: equal
    expected: '5月前'
    actual:   '4月前'
    at: module.exports (/Users/oscarotero/www/timeago.js/tests/locales/zh_CN.js:49:5)
    stack: |-
      Error: should be equal
          at Test.assert [as _assert] (/Users/oscarotero/www/timeago.js/node_modules/tape/lib/test.js:212:54)
          at Test.bound [as _assert] (/Users/oscarotero/www/timeago.js/node_modules/tape/lib/test.js:64:32)
          at Test.equal.Test.equals.Test.isEqual.Test.is.Test.strictEqual.Test.strictEquals (/Users/oscarotero/www/timeago.js/node_modules/tape/lib/test.js:347:10)
          at Test.bound [as equal] (/Users/oscarotero/www/timeago.js/node_modules/tape/lib/test.js:64:32)
          at module.exports (/Users/oscarotero/www/timeago.js/tests/locales/zh_CN.js:49:5)
          at files.forEach.file (/Users/oscarotero/www/timeago.js/tests/test.js:18:37)
          at Array.forEach (native)
          at fs.readdir (/Users/oscarotero/www/timeago.js/tests/test.js:13:11)
          at FSReqWrap.oncomplete (fs.js:135:15)

But travis execute the tests successfully, not sure why. Note that the error is in the number not in the text. Maybe is related with the timezone issue #136 ?

@hustcc hustcc merged commit 0c806d0 into hustcc:master Jul 20, 2017
@oscarotero oscarotero deleted the patch-1 branch July 20, 2017 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants