Some of the IK Fixes From CIRC #338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/TunePID.cpp
Outdated
| can::motor::setMotorPIDConstants(serial, p_coeff, i_coeff, d_coeff); | ||
|
|
||
| // can::motor::setMotorPIDMaxPower(serial, 32767); // this was here from circ |
There was a problem hiding this comment.
For now you can just remove this
src/TunePID.cpp
Outdated
| @@ -159,7 +166,7 @@ int main(int argc, char** argv) { | |||
| if (mode == targetmode_t::step) { | |||
| prescaled_target = round(prescaled_target); | |||
| } | |||
| angle_target = (int32_t) round(amplitude * prescaled_target) + starting_angle; | |||
| angle_target = (int32_t)round(amplitude * prescaled_target) + starting_angle; | |||
There was a problem hiding this comment.
can you make this a static_cast
| @@ -1,5 +1,6 @@ | |||
| #pragma once | |||
|
|
|||
| #include <algorithm> | |||
There was a problem hiding this comment.
Is this include needed?
There was a problem hiding this comment.
The std::transform function is from the algorithm header. It should have been there to begin with, and I assume that one of the other headers includes it, but we probably shouldn't rely on other headers to include what we want
| {{motorid_t::shoulder, {70, 0, 0}}, | ||
| {{motorid_t::shoulder, {200, 0, 0}}, | ||
| {motorid_t::elbow, {250, 0, 0}}, | ||
| // swerve constants need to be updated when firmware changes PID scaling |
There was a problem hiding this comment.
Can you mark this a FIXME and then also state that the numbers should be in the 100s?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes from the IK fixes from CIRC 723c6fd are addressed in this PR. The exception is with the sleep function in the
TunePID.cppfile, which will be addressed in another PR.