Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify CAN Motor implementation #317

Merged
merged 6 commits into from
Apr 26, 2024
Merged

Unify CAN Motor implementation #317

merged 6 commits into from
Apr 26, 2024

Conversation

DrDab
Copy link
Contributor

@DrDab DrDab commented Apr 16, 2024

Merge the functionality of CANMotor_PSOC.cpp into CANMotor.cpp since CANMotor_AVR.cpp is no longer used

Copy link
Member

@abhaybd abhaybd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note about includes, but looks good otherwise. Can you make sure it's up to date with master?

src/CAN/CANMotor.cpp Outdated Show resolved Hide resolved
Copy link
Member

@abhaybd abhaybd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you just ensure it's up to date with master, and then merge?

@DrDab DrDab merged commit 1a46e00 into master Apr 26, 2024
3 checks passed
@DrDab DrDab deleted the UnifyCANImplementation branch April 26, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants