Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle IK failure gracefully #304

Merged
merged 2 commits into from
Jan 28, 2024
Merged

Handle IK failure gracefully #304

merged 2 commits into from
Jan 28, 2024

Conversation

abhaybd
Copy link
Member

@abhaybd abhaybd commented Jan 26, 2024

Before, the velocity wouldn't get set to zero so the arm wouldn't move but the setpoint would keep moving at the current velocity. This PR ensure it gets handled properly, so the velocity is reset and the setpoint is made to be correct.

Copy link
Contributor

@quinnmp quinnmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abhaybd abhaybd merged commit 4e3f816 into master Jan 28, 2024
3 checks passed
@abhaybd abhaybd deleted the handle-ik-failure branch January 28, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants