Add tasks to utils #300
Merged
Add tasks to utils #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnmp
reviewed
Jan 23, 2024
huttongrabiel
requested changes
Jan 26, 2024
|
@abhaybd Formatting errors on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in the process of cleaning up MissionControlProtocol, and factoring out the tasks from the big class into their own individual classes that encapsulate their own state.
This PR adds the required task classes and unit tests, in preparation of that.
I'm reasonably sure I caught any data races in
AsyncTask, but let me know if you find any others!