Upgrade format checker CI to clang-format-18 #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhaybd
force-pushed
the
upgrade-format-ci
branch
from
6f2f7be to
316754d
Compare
quinnmp
reviewed
Dec 9, 2023
| - name: Check Formatting | ||
| run: | | ||
| cd ${{ github.workspace }} | ||
| git reset --soft $(git merge-base HEAD origin/master) | ||
| diff=$(git clang-format-11 --diff) | ||
| diff=$(git clang-format-18 --style=file --diff) |
There was a problem hiding this comment.
I think you were right about --style=file, it should be the default, so I think no need for it here unless you want to be really clear that we're formatting from a file
There was a problem hiding this comment.
Yeah, I figured we might as well be explicit about it. Saves us the trouble of going and finding the docs next time we forget if that's the default or not
quinnmp
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously using 11, which has a bug that was messing with our enums. Upgrading to 18 should fix this.