Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vestigial and unused code #291

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Remove vestigial and unused code #291

merged 1 commit into from
Dec 9, 2023

Conversation

abhaybd
Copy link
Member

@abhaybd abhaybd commented Dec 9, 2023

We don't use any of this code anymore, and it was just taking up space and making things look a lot messier.

quinnmp
quinnmp approved these changes Dec 9, 2023
View reviewed changes
Copy link
Contributor

@quinnmp quinnmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not as familiar with the entire code base, but everything compiles, runs, and tests pass on my end.

huttongrabiel
huttongrabiel approved these changes Dec 9, 2023
View reviewed changes
Copy link
Contributor

@huttongrabiel huttongrabiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds and passes tests for me too. lgtm

@abhaybd abhaybd merged commit f21ed5a into master Dec 9, 2023
3 checks passed
@abhaybd abhaybd deleted the remove-vestigial-code branch December 9, 2023 21:59
Geeoon pushed a commit that referenced this pull request Jan 8, 2024
@abhaybd @Geeoon
Remove vestigial and unused code (#291)
80965ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnmp quinnmp quinnmp approved these changes

@huttongrabiel huttongrabiel huttongrabiel approved these changes

@Geeoon Geeoon Awaiting requested review from Geeoon

@sarahfredrickson sarahfredrickson Awaiting requested review from sarahfredrickson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhaybd @huttongrabiel @quinnmp