Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change AR_CAMERA to MAST_CAMERA #281

Merged
merged 5 commits into from
Jan 27, 2024
Merged

change AR_CAMERA to MAST_CAMERA #281

merged 5 commits into from
Jan 27, 2024

Conversation

SriramKodey
Copy link
Contributor

Change Camera name from AR_CAMERA to MAST_CAMERA for consistency

@SriramKodey SriramKodey requested a review from abhaybd November 7, 2023 03:21
abhaybd
abhaybd requested changes Nov 7, 2023
View reviewed changes
Copy link
Member

@abhaybd abhaybd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good! I think the autoformatter is complaining though, just take a look at that.

abhaybd
abhaybd previously approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@abhaybd abhaybd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@quinnmp quinnmp requested a review from imisaacwu January 27, 2024 19:35
@quinnmp quinnmp merged commit cb74553 into master Jan 27, 2024
3 checks passed
@quinnmp quinnmp deleted the change_cam_name_mast branch January 27, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imisaacwu imisaacwu imisaacwu approved these changes

@abhaybd abhaybd abhaybd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SriramKodey @abhaybd @imisaacwu @quinnmp