Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete and remove all references to Util.h #277

Merged
merged 3 commits into from
Oct 28, 2023
Merged

Delete and remove all references to Util.h #277

merged 3 commits into from
Oct 28, 2023

Conversation

quinnmp
Copy link
Contributor

@quinnmp quinnmp commented Oct 27, 2023

This removes all import references to Util.h and replaces them with the correct util file. Also, delete Util.h entirely.

@quinnmp quinnmp requested a review from abhaybd October 28, 2023 18:21
abhaybd
abhaybd approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@abhaybd abhaybd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I'd say to avoid formatting code that's untouched by your PR and instead create a separate formatting PR, but this should be fine. Nice job getting this done quickly!

@abhaybd abhaybd merged commit 6c18297 into master Oct 28, 2023
3 checks passed
@abhaybd abhaybd deleted the remove-Util.h branch October 28, 2023 18:47
AyushKulk pushed a commit that referenced this pull request Oct 31, 2023
@quinnmp @AyushKulk
Delete and remove all references to Util.h (#277)
19d48df 
* Delete and remove all references to Util.h

* Resolve additional util imports

* Fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhaybd abhaybd abhaybd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quinnmp @abhaybd