allow install script to handle tags and system extension #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apackel-huntress
requested review from
abstract-surfer,
uttie-huntress,
Alan-Huntress and
sk-huntress
|
@Alan-Huntress I've done some testing with the new options and they should work as expected, but feel free to tell me if I've missed anything (or to suggest changes to the logging or anything else). |
|
@apackel-huntress looks good to me but I'm far from a bash wizard! The basics of logging are there, if anything comes up that needs adjustment I'll bring it to the teams attention. People always find interesting ways to break things so being able to change our scripts to compensate is clutch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the bash install script to handle
--tagsand--install_system_extensionoptions and pass those to the "internal" install script it downloads from the Huntress CDN.