Added reregister flag and additional logging #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Key changes: -Reregister flag (-r) will remove Huntress prior to reinstalling it -If Huntress is detected on the machine the installer won't proceed unless the reregister flag is passed -More verbose logging for troubleshooting -Grouped functions together to make the main code easier to read.
mfischerhuntress
requested review from
evanburkeyhl,
sk-huntress,
apackel-huntress and
uttie-huntress
evanburkeyhl
reviewed
Dec 2, 2024
apackel-huntress
approved these changes
Dec 2, 2024
|
|
||
| countProcesses=$(ps aux | grep "HuntressAgent" -c) | ||
| if [ $countProcesses -le 1 ]; then | ||
| logger "Huntress process not running, System Extension may hang for a minute on uninstall" |
There was a problem hiding this comment.
Is there a reason this message references the system extension specifically? Whether the Go agent (HuntressAgent) is running shouldn't have any effect on the removal of the extension. We'd need to check whether the Swift daemon (aka plain old Huntress) is running, since that's what's responsible for the extension.
There was a problem hiding this comment.
It was just something I noticed from testing. If I killed the Huntress processes before trying to remove the System Extension then the SE removal would pause for a period of time. I can adjust this to look for only plain Huntress instead.
evanburkeyhl
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key changes:
-Reregister flag (-r) will remove Huntress prior to reinstalling it -If Huntress is detected on the machine the installer won't proceed unless the reregister flag is passed -More verbose logging for troubleshooting
-Grouped functions together to make the main code easier to read.