You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While @sveltejs/enhanced-img is a great plugin for optimizing images for SK, it unfortunately slows down our build pipeline by a significant amount. Previously, it would take a little under 2 minutes to complete a fresh build, whereas now it takes about 8 minutes.
Currently, there's no available plugin/config option to cache the generated images, meaning that all images need to be processed (twice!) on every build. Our little GH runner just can't keep up.
We'll reevaluate once the ability to cache is implemented.
Before submitting the PR, please make sure you do the following
If your PR isn't addressing a small fix (like a typo), it references an issue where it is discussed ahead of time and assigned to you. In many cases, features are absent for a reason.
Prefix your PR title with feat:, fix:, chore:, or docs:.
This message body should clearly illustrate what problems it solves.
Format & lint the code with pnpm format and pnpm lint
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Given this recent P.R landing, JonasKruckenberg/imagetools#661, does this sound like a solution to the problem, ergo worth it re-introducing enhanced-img? (My assumption is that that tool powers enhanced-img, right?)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While
@sveltejs/enhanced-imgis a great plugin for optimizing images for SK, it unfortunately slows down our build pipeline by a significant amount. Previously, it would take a little under 2 minutes to complete a fresh build, whereas now it takes about 8 minutes.Currently, there's no available plugin/config option to cache the generated images, meaning that all images need to be processed (twice!) on every build. Our little GH runner just can't keep up.
We'll reevaluate once the ability to cache is implemented.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.pnpm formatandpnpm lint