fix(next): ensure registry:ui components don't depend on themselves (#…

…1490) Co-authored-by: AdrianGonz97 <[email protected]> fixes #1489
huntabyte · Nov 15, 2024 · a817cfb · a817cfb
1 parent 378b615
commit a817cfb
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 11 deletions.
diff --git a/sites/docs/scripts/build-registry.ts b/sites/docs/scripts/build-registry.ts
@@ -39,6 +39,15 @@ function writeFileWithDirs(
 
 async function main() {
 	const registry = await buildRegistry();
+
+	const selfReferenced = registry.filter((item) => item.registryDependencies.includes(item.name));
+	const selfReferenceError = selfReferenced
+		.map((item) => `Registry item '${item.name}' depends on itself`)
+		.join("\n");
+	if (selfReferenceError) {
+		throw new Error(selfReferenceError);
+	}
+
 	const result = registrySchema.safeParse(registry);
 
 	if (!result.success) {

diff --git a/sites/docs/src/lib/registry/default/ui/data-table/flex-render.svelte b/sites/docs/src/lib/registry/default/ui/data-table/flex-render.svelte
@@ -10,10 +10,7 @@
 	lang="ts"
 	generics="TData, TValue, TContext extends HeaderContext<TData, TValue> | CellContext<TData, TValue>"
 >
-	import {
-		RenderComponentConfig,
-		RenderSnippetConfig,
-	} from "$lib/registry/default/ui/data-table/render-helpers.js";
+	import { RenderComponentConfig, RenderSnippetConfig } from "./render-helpers.js";
 	type Props = {
 		/** The cell or header field of the current cell's column definition. */
 		content?: TContext extends HeaderContext<TData, TValue>

diff --git a/sites/docs/src/lib/registry/default/ui/toggle-group/toggle-group-item.svelte b/sites/docs/src/lib/registry/default/ui/toggle-group/toggle-group-item.svelte
@@ -1,6 +1,6 @@
 <script lang="ts">
 	import { ToggleGroup as ToggleGroupPrimitive } from "bits-ui";
-	import { getToggleGroupCtx } from "$lib/registry/default/ui/toggle-group/toggle-group.svelte";
+	import { getToggleGroupCtx } from "./toggle-group.svelte";
 	import { cn } from "$lib/utils.js";
 	import { type ToggleVariants, toggleVariants } from "$lib/registry/default/ui/toggle/index.js";
 

diff --git a/sites/docs/src/lib/registry/new-york/ui/data-table/flex-render.svelte b/sites/docs/src/lib/registry/new-york/ui/data-table/flex-render.svelte
@@ -9,10 +9,7 @@
 	lang="ts"
 	generics="TData, TValue, TContext extends HeaderContext<TData, TValue> | CellContext<TData, TValue>"
 >
-	import {
-		RenderComponentConfig,
-		RenderSnippetConfig,
-	} from "$lib/registry/new-york/ui/data-table/render-helpers.js";
+	import { RenderComponentConfig, RenderSnippetConfig } from "./render-helpers.js";
 
 	type Props = {
 		/** The cell or header field of the current cell's column definition. */

diff --git a/sites/docs/src/lib/registry/new-york/ui/select/select-content.svelte b/sites/docs/src/lib/registry/new-york/ui/select/select-content.svelte
@@ -1,6 +1,6 @@
 <script lang="ts">
 	import { Select as SelectPrimitive, type WithoutChild } from "bits-ui";
-	import * as Select from "$lib/registry/new-york/ui/select/index.js";
+	import * as Select from "./index.js";
 	import { cn } from "$lib/utils.js";
 
 	let {

diff --git a/sites/docs/src/lib/registry/new-york/ui/toggle-group/toggle-group-item.svelte b/sites/docs/src/lib/registry/new-york/ui/toggle-group/toggle-group-item.svelte
@@ -1,6 +1,6 @@
 <script lang="ts">
 	import { ToggleGroup as ToggleGroupPrimitive } from "bits-ui";
-	import { getToggleGroupCtx } from "$lib/registry/new-york/ui/toggle-group/toggle-group.svelte";
+	import { getToggleGroupCtx } from "./toggle-group.svelte";
 	import { cn } from "$lib/utils.js";
 	import { type ToggleVariants, toggleVariants } from "$lib/registry/new-york/ui/toggle/index.js";