Improve reviewability of WebNN operations baseline #1
Conversation
To help readability of the core algorithms
There was a problem hiding this comment.
Thanks much @dontcallmedom !
Lint tool reports a few errors. Please take a look. You can run the lint tool locally by npm run lint. If you found lint rules are inappropriate, feel free to update the rules accordingly.
src/lib/validate-input.js
Outdated
| } | ||
| } | ||
|
|
||
| export function validateInput(op, args) { |
There was a problem hiding this comment.
Should we have specific method (or even separate file) for each op's validation? Say, validateConv2dInput etc.,
There was a problem hiding this comment.
if we keep input validation, and if we keep it separate, separate methods are probably indeed much cleaner; I'm not sure separate files are necessary warranted, but I don't mind strongly either
There was a problem hiding this comment.
Regarding to discussion, it looks like we agree to keep the input validation code. So could you please make separate methods for them? I agree with you we can skip the separate files.
There was a problem hiding this comment.
Thanks @dontcallmedom for the update. My only open is about separate methods for input validation. Other code LGTM.
src/lib/validate-input.js
Outdated
| } | ||
| } | ||
|
|
||
| export function validateInput(op, args) { |
There was a problem hiding this comment.
Regarding to discussion, it looks like we agree to keep the input validation code. So could you please make separate methods for them? I agree with you we can skip the separate files.
No description provided.