Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) add pem check #196

Merged
merged 1 commit into from
Sep 4, 2023
Merged

(fix) add pem check #196

merged 1 commit into from
Sep 4, 2023

Conversation

fengtality
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • added a check for lack of .pem files when running the Gateway setup script

Tests performed by the developer:

Tips for QA testing:

rapcmia
rapcmia approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@rapcmia rapcmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gateway-setup.sh script does not accept a dir without .pem files

@rapcmia
Copy link
Contributor

rapcmia commented Sep 4, 2023

Merged to development and part of release version 1.20.0

@rapcmia rapcmia merged commit acbadba into development Sep 4, 2023
5 checks passed
@rapcmia rapcmia deleted the fix/add-pem-check branch September 4, 2023 04:32
@nikspz nikspz mentioned this pull request Sep 25, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rapcmia rapcmia rapcmia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pull Request Status
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fengtality @rapcmia