Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/base page class #47

Merged
merged 11 commits into from
Jul 24, 2023
Merged

Feat/base page class #47

merged 11 commits into from
Jul 24, 2023

Conversation

fengtality
Copy link
Contributor

This PR standardizes the layout of each page:

  • Incorporates https://github.com/blackary/st_pages to support multi-page apps
  • Puts each page into its own sub-directory with a README
  • Standardizes the top level meta-data for each page

@fengtality
Copy link
Contributor Author

LGTM!

cardosofede
cardosofede approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cardosofede cardosofede merged commit 1f5e9f0 into main Jul 24, 2023
@cardosofede cardosofede deleted the feat/base-page-class branch July 24, 2023 16:17
@fengtality fengtality mentioned this pull request Jul 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cardosofede cardosofede cardosofede approved these changes

@cryptojorge cryptojorge Awaiting requested review from cryptojorge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fengtality @cardosofede