Make RollingUpdateBestEffort behave a bit more like RollingUpdate #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current behavior is such that the RollingUpdateBestEffort is only applicable in the case of a Logscale version change. There are times when other parameters change on a HumioCluster CR where it would be ideal to have a rolling update but there is no version change.
RollingUpdateBestEffort will act like RollingUpdate unless there is a version upgrade in play. In that case the version comparison logic will take over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is somewhat surprising behavior, at least to me, that the "best effort" strategy is only considered in the case of a Logscale version update. I think it makes more sense to have it behave like
RollingUpdateunless there is a version upgrade in which case the version comparison logic can take over. This will allow things like modifications to environment variables which need to restart pods to have a rolling update even if there is no version update at the same time.