fix: validate Score files locally when there is no org set #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -144,6 +144,7 @@ export class HumanitecSidebarController { | |||
| item.id | |||
| ); | |||
| } | |||
| vscode.commands.executeCommand('humanitec.score.validate'); | |||
There was a problem hiding this comment.
I wonder if a better solution wouldn't be to listen for configuration changes in the score validation controller instead of directly calling between them.
This way any config change would be detected, no matter how its being written.
There was a problem hiding this comment.
Good idea. I'll refactor the configuration repository with observer pattern in the next PR
mateuszjenek
force-pushed
the
validate_score_local_when_no_org
branch
2 times, most recently
from
a256f42
to
c2cabc7
Compare
mateuszjenek
force-pushed
the
validate_score_local_when_no_org
branch
from
c2cabc7
to
8fcdbf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is no org set the local validation is executed with the proper status displayed in the status bar