-
-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup pre-commit
for GEF
#984
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Coverage Update
|
theguy147
approved these changes
Aug 7, 2023
therealdreg
requested changes
Aug 7, 2023
Fixed bad link ref spotted by dreg
therealdreg
approved these changes
Aug 7, 2023
🤖 Coverage Update
To this point, this PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description/Motivation/Screenshots
This PR adds
pre-commit
to facilitate and unify the formatting of everything in this project (code, test, docs, ci).Aside from
.pre-commit-config.yml
anddocs/.markdownlint.yaml
, all the other changes are purely cosmetic, applying markdownlint and fixing here and there to make it pass.It also creates a new CI job that'll simply execute
pre-commit
for new PRs.Against which architecture was this tested ?
"Tested" indicates that the PR works and the unit test (see
docs/testing.md
) run passes without issue.N/A
Checklist