Python 3.10 improvements #1139
Draft
Python 3.10 improvements #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grazfather
reviewed
Sep 24, 2024
| assert res | ||
| groups = [int(d) for d in res.groups()] | ||
| assert len(groups) == 2 | ||
| return (groups[0], groups[1]) |
There was a problem hiding this comment.
Suggested change
| return (groups[0], groups[1]) | |
| return groups[0], groups[1] |
| self.commands : Dict[str, GenericCommand] = collections.OrderedDict() | ||
| self.functions : Dict[str, GenericFunction] = collections.OrderedDict() | ||
| self.missing: Dict[str, Exception] = {} | ||
| self.commands : dict[str, GenericCommand] = collections.OrderedDict() |
There was a problem hiding this comment.
don't we not need ordered dicts anymore?
| @@ -11063,7 +11071,7 @@ def selected_arena(self, value: GlibcArena) -> None: | |||
| return | |||
|
|
|||
| @property | |||
| def arenas(self) -> Union[List, Iterator[GlibcArena]]: | |||
| def arenas(self) -> list | Iterator[GlibcArena]: | |||
There was a problem hiding this comment.
If you want to use | I think there are many more cases where we can get rid of Union
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up PR for #1133
Cleans up the code to make it more in comformance with Python 3.10 capabilities.