Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data mixer Integration #2240

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

August-murr
Copy link
Contributor

What does this PR do?

Fixes #2112
just putting this up as a demo. I didn’t get feedback on whether this should be part of trl or datasets, so I tried integrating a data mixer using a JSON config file.

  • There are a few caveats—like the JSON file might not be beginner-friendly, and there aren’t any default values, so things can break if the config isn’t right.
  • It’s currently limited to CLI usage since It was prioritized. Let me know if you’d like it extended for other use cases.
  • I’m not sure if I put the functions/files in the right locations, so feel free to suggest better locations.

I’ve also included this script to show that it works. Let me know what you think or if this should be structured differently!

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

@lewtun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data] Implement dataset mixer for combining datasets in training
2 participants