Update config validation #34726
Open
Update config validation #34726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing tests seem unrelated to my changes and all tests passed locally for me, is there something I'm missing here? |
Comment on lines
+571
to
+572
| integer_arguments = ["num_beams", "num_beam_groups", "top_k", "no_repeat_ngram_size"] | ||
| positive_arguments = [ |
There was a problem hiding this comment.
we can add all integer values in positive values, as they cannot be negative anyways. So we check in one place if it is a positive integer
| "num_beam_groups", | ||
| "no_repeat_ngram_size", | ||
| ] | ||
| probability_arguments = ["top_p", "typical_p", "min_p", "epsilon_cutoff", "eta_cutoff"] |
There was a problem hiding this comment.
can also check on positive float numbers which are: diversity-penalty, repetition-penalty, encoder-repetition-penalty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #33690
This PR adds extra validation for generation parameters to fail early when invalid values are passed and not let things fail silently as suggested in the issue.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@gante @zucchini-nlp