Forcing byte order in numpy at load time (Fixes loading a safetensor from a big endian machine). #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from a big endian machine).
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
sgugger
approved these changes
Mar 13, 2023
Ah, I didn't review because I was counting on you to know what was happening here 😄 I'll take a look in a bit @Narsil |
|
Closing in favor of #310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #190 I guess.
Would be nice to know what happens with Pytorch and endianess too to find a similar fix.
Seems the buffer is not modified so speed shouldn't suffer.
https://numpy.org/doc/stable/reference/generated/numpy.ndarray.newbyteorder.html
Also:
https://lkml.org/lkml/2015/4/24/606
Not sure how many machines are really running big endian, or how to get access or emulate to test all this.