Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Skip EETQ tests while broken #2226

Merged

Conversation

BenjaminBossan
Copy link
Member

EETQ tries to import the shard_checkpoint function from transformers but it has been removed in the latest version. Therefore, trying to use EETQ currently results in an import error that crashes all the tests. This fix results in EETQ tests being skipped if there is an import error.

The issue has been reported to EETQ: NetEase-FuXi/EETQ#34

EETQ tries to import the shard_checkpoint function from transformers but
it has been removed in the latest version. Therefore, trying to use EETQ
currently results in an import error that crashes all the tests. This
fix results in EETQ tests being skipped if there is an import error.

The issue has been reported to EETQ:

NetEase-FuXi/EETQ#34
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this ! LGTM ! If you have some time, could you also do it for transformers ?

@BenjaminBossan BenjaminBossan merged commit 0155fa8 into huggingface:main Nov 21, 2024
14 checks passed
@BenjaminBossan BenjaminBossan deleted the ci-skip-eetq-tests-while-broken branch November 21, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants